Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links in the documentation #97

Closed
pnsaevik opened this issue Oct 31, 2023 · 3 comments
Closed

Broken links in the documentation #97

pnsaevik opened this issue Oct 31, 2023 · 3 comments

Comments

@pnsaevik
Copy link

The link to the ETOPO dataset at https://macekuailv.github.io/seaduck/sciserver_notebooks/KangerFjord.html is broken. Ideally, there should be a test in place to warn developers about broken links. I tried the solution outlined in the Jupyterbook documentation, but I could not get it to work. Maybe you have better luck?

This issue is a part of a JOSS review at openjournals/joss-reviews#5967
@MaceKuailv
Copy link
Owner

Oh no, I thought those links are going to be pretty stable. It makes sense to have automatic checks. I will try to implement that.

This was referenced Oct 31, 2023
Closed
Merged
@MaceKuailv
Copy link
Owner

I have added a optional manual check and fix the existing wrong links in PR #99.

However, I don't want to merge it just yet. This is because this is a pretty small fix and I would expect more from No. 99 :)

@MaceKuailv MaceKuailv mentioned this issue Nov 22, 2023
Merged
@MaceKuailv
Copy link
Owner

This is resolved by PR 107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pnsaevik @MaceKuailv