-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rennovate notebook documentation #1
Comments
The mask of U,V and W are generated like this: The variables on the wall is only masked if both of the cells the wall is separating is masked, which means that the masked cells are examined almost one by one (I need to check again). This does not make difference when the kernel diameter is smaller than 3 grid points and the mask value of velocity is zero or nan. I guess I can make a switch to skip this step if the kernel is too small. Thanks for drawing attention on this. |
OK. This is a once-only calculation, right? I suggest adding to code to check if the files exist. If so, read them. If not, build them. |
small demo.ipynb
comments
This is a pretty old issue, and the notebook I will use this issue as a hub for creating and ticking to-do lists. I will iterate until someday I close this issue. Someday, the documentation will be actually good. Yes, someday. Many issues mentioned by @ThomasHaine is already resolved during the past year. Here are a few things that I still need to work on for existing notebooks.
Here are a few wishlist notebooks that I want to make:
|
I am happy about the documentation. |
Here are some comments (list of fixes/updates) on
small demo.ipynb
. These are intended to turn it into a more useful getting-started quickly demonstration.[x,y,z,t]
values you're interpolating, e.g. in cell 4.raw
variable. E.g., what's the particle depth?The text was updated successfully, but these errors were encountered: