-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace intarray with gc_vector<int>, combine varpower types + range-based loops #2770
Conversation
For the replacement name for |
@mahrud I'm going to start reviewing this so we will be ready once we choose the replacement name for varpower monomials |
(everywhere except in varpower files, which comes next)
15df2f7
to
c1fda29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mahrud, thanks for making these changes! I have flagged a few places where there might be an issue. Once you look at those, I'll accept this pull request. I'd also like @antonleykin to see how his NAG code had changed, so it won't come as a surprise later!
This commit replaces the type
intarray
throughout the engine with a specialization ofstd::vector
which uses the GC allocator:Note:
gc_vector<T>
is basicallyVECTOR(T)
, so at some point I'll also replace allVECTOR(T)
with the newgc_vector<T>
syntax.This commit replaces the varpower types into a templated type that uses
gc_vector<int>
:The last two commits are pretty minor changes: