From b39f19859881e0f30499845570bd9a29a460bb14 Mon Sep 17 00:00:00 2001 From: Martin Vrachev Date: Tue, 1 Jun 2021 17:10:06 +0300 Subject: [PATCH] Remove question about version validation place In issue #1418 in this comment: https://github.com/theupdateframework/tuf/issues/1418#issuecomment-852147689 I summarized the discussion we had with the participants in this issue. In summary: no additional changes are needed for "version" validation considering there is "bump_version()" function for that. If we won't be adding "version" validation elsewhere we can keep it the way it is. Signed-off-by: Martin Vrachev --- tuf/api/metadata.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tuf/api/metadata.py b/tuf/api/metadata.py index c3faafbdd5..6087dc8202 100644 --- a/tuf/api/metadata.py +++ b/tuf/api/metadata.py @@ -346,7 +346,6 @@ def __init__( self.spec_version = spec_version self.expires = expires - # TODO: Should we separate data validation from constructor? if version <= 0: raise ValueError(f"version must be > 0, got {version}") self.version = version