Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vamp plugin "segmentation fault" #635

Closed
sildeag opened this issue Aug 14, 2017 · 7 comments
Closed

vamp plugin "segmentation fault" #635

sildeag opened this issue Aug 14, 2017 · 7 comments
Labels

Comments

@sildeag
Copy link

sildeag commented Aug 14, 2017

On Ubuntu 17.04 64-bit, Essentia 2.1, with clean build from source code --with-vamp:

libvamp_essentia.so is excluded from vamp plugins used by "sonic-visualiser 3.0." vamp plugin test fails indicating "segmentation fault." The same problem affects "audacity" except it just crashes and "sonic-annotator."

Essentia uses vamp sdk version 2.4 and latest version of vamp sdk is 2.7. Would changes made to wscript in src/examples folder be the correct place to upgrade the build so that vamp sdk 2.7 is used rather than 2.4? I would like to use something like this.

VAMP_SDK_DIR = /home/<user name>/vamp-plugin-sdk and

# Libraries required for the plugins.
#
PLUGIN_LIBS = -L../vamp-plugin-sdk/vamp-sdk -Wl,-Bstatic -lvamp-sdk -Wl,-Bdynamic -lpthread

# Flags required to tell the compiler to make a dynamically loadable object
#
PLUGIN_LDFLAGS = -shared -Wl,-Bdynamic -Wl,-soname=$(PLUGIN) $(VAMP_SDK_DIR)/libvamp-sdk.a -Wl,--version-script=vamp-plugin.map

# File extension for a dynamically loadable object
#
PLUGIN_EXT = .so

Are there any special flags that should be used in "essentia 2.1"?

@dbogdanov
Copy link
Member

No problems running the newest Sonic Visualizer v3.0.3 and sonic-annotator v1.5 on Mac OSX with the Essentia's vamp plugin built with the old SDK. Also, sonic-annotator v1.5 works fine with it on my Ubuntu 16.04 too.

@dbogdanov dbogdanov added the bug label Aug 18, 2017
@dbogdanov
Copy link
Member

@sildeag Correct, you can modify src/examples/wscript if you want to.

@dbogdanov
Copy link
Member

I get setfault in sonic-annotator on Ubuntu, when using the --build-static flag in waf configure to build the Vamp plugin. Will look into this now...

dbogdanov added a commit that referenced this issue Aug 31, 2017
Fix segfault that would occure in the Vamp plugin if Essentia was
built with --build-static flag. Store Algorithm::name, category and
description always in the standard scope.
@dbogdanov
Copy link
Member

Fixes are to be merged in master.

@sildeag
Copy link
Author

sildeag commented Sep 2, 2017 via email

@dbogdanov
Copy link
Member

We'll update to Vamp 2.7 in future, but the issue was not related to that.

@sildeag
Copy link
Author

sildeag commented Sep 9, 2017

Thanks. Yes, with the revisions you made vamp plugin works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants