Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add variable name to metadata #84

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Conversation

shouples
Copy link
Collaborator

With ENABLE_DATALINK=True, this will ensure variable names associated with dataframes are passed in the IPython.display metadata.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Merging #84 (ae60def) into main (31bc6f7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files          27       27           
  Lines        1306     1306           
=======================================
  Hits         1086     1086           
  Misses        220      220           
Impacted Files Coverage Δ
src/dx/formatters/main.py 88.50% <100.00%> (ø)
src/dx/utils/formatting.py 94.06% <100.00%> (ø)
src/dx/utils/tracking.py 97.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bc6f7...ae60def. Read the comment docs.

@shouples shouples merged commit 6b2e68c into main Oct 28, 2022
@shouples shouples deleted the djs/variable-name-to-metadata branch October 28, 2022 20:57
@shouples shouples added this to the DEX to Kernel Sync milestone Oct 28, 2022
@shouples shouples changed the title add variable name to metadata Closes #82: add variable name to metadata Oct 28, 2022
@shouples shouples linked an issue Oct 28, 2022 that may be closed by this pull request
@shouples shouples added the enhancement New feature or request label Nov 3, 2022
@shouples shouples changed the title Closes #82: add variable name to metadata add variable name to metadata Nov 3, 2022
shouples added a commit that referenced this pull request Nov 14, 2022
* add df variable name to output metadata

* pass variable name into metadata

* add metadata tests

* move non-DXDataFrame metadata assertions to separate tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pass dataframe variable name into DEX metadata
2 participants