Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use duckdb instead of sqlite #52

Merged
merged 9 commits into from
Sep 26, 2022
Merged

use duckdb instead of sqlite #52

merged 9 commits into from
Sep 26, 2022

Conversation

shouples
Copy link
Collaborator

@shouples shouples commented Sep 23, 2022

following the lead of

TODO:

  • check if the .index persists in duckdb or if it has to be re-set after filtering
    • it does not persist and has to be reset before registration

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #52 (adb4b6f) into main (3edff12) will increase coverage by 8.29%.
The diff coverage is 96.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   79.01%   87.31%   +8.29%     
==========================================
  Files          19       19              
  Lines        1101     1088      -13     
==========================================
+ Hits          870      950      +80     
+ Misses        231      138      -93     
Impacted Files Coverage Δ
src/dx/comms.py 60.00% <76.92%> (+30.37%) ⬆️
src/dx/utils/datatypes.py 92.02% <87.50%> (-1.23%) ⬇️
src/dx/formatters/main.py 88.50% <91.66%> (+2.63%) ⬆️
src/dx/filtering.py 100.00% <100.00%> (+79.36%) ⬆️
src/dx/settings.py 87.59% <100.00%> (+0.09%) ⬆️
src/dx/types.py 96.11% <100.00%> (+28.76%) ⬆️
src/dx/utils/date_time.py 73.68% <100.00%> (-21.06%) ⬇️
src/dx/utils/formatting.py 83.87% <100.00%> (+3.87%) ⬆️
src/dx/utils/geometry.py 79.54% <100.00%> (ø)
src/dx/utils/tracking.py 97.46% <100.00%> (+12.20%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250f35a...adb4b6f. Read the comment docs.

@shouples shouples marked this pull request as ready for review September 26, 2022 17:18
@shouples shouples merged commit e6886ad into main Sep 26, 2022
@shouples shouples deleted the djs/duckdb-swap branch September 26, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants