Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe renaming comms listener #49

Merged
merged 10 commits into from
Oct 11, 2022
Merged

Dataframe renaming comms listener #49

merged 10 commits into from
Oct 11, 2022

Conversation

MSeal
Copy link
Owner

@MSeal MSeal commented Sep 23, 2022

I added an untested dataframe renaming comms handler for review as part of the spike into how to manage non-executing output renaming.

Used by https://github.com/noteable-io/planar-ally/pull/299

@MSeal MSeal marked this pull request as draft September 23, 2022 04:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #49 (1bf2df1) into main (3edff12) will increase coverage by 7.15%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   79.01%   86.17%   +7.15%     
==========================================
  Files          19       19              
  Lines        1101     1128      +27     
==========================================
+ Hits          870      972     +102     
+ Misses        231      156      -75     
Impacted Files Coverage Δ
src/dx/comms.py 41.17% <36.84%> (+11.54%) ⬆️
src/dx/formatters/main.py 88.50% <91.66%> (+2.63%) ⬆️
src/dx/utils/datatypes.py 92.69% <95.65%> (-0.56%) ⬇️
src/dx/filtering.py 100.00% <100.00%> (+79.36%) ⬆️
src/dx/settings.py 87.68% <100.00%> (+0.18%) ⬆️
src/dx/types.py 96.11% <100.00%> (+28.76%) ⬆️
src/dx/utils/date_time.py 73.68% <100.00%> (-21.06%) ⬇️
src/dx/utils/formatting.py 83.87% <100.00%> (+3.87%) ⬆️
src/dx/utils/geometry.py 79.54% <100.00%> (ø)
src/dx/utils/tracking.py 97.53% <100.00%> (+12.26%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ddaaa7...1bf2df1. Read the comment docs.

@jlrobins jlrobins changed the title WIP example of dataframe renaming comms listener Dataframe renaming comms listener Oct 7, 2022
@jlrobins jlrobins marked this pull request as ready for review October 7, 2022 14:33
@jlrobins jlrobins merged commit caceb97 into main Oct 11, 2022
@jlrobins jlrobins deleted the dataframe_rename branch October 11, 2022 14:12
shouples pushed a commit that referenced this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants