WIP - dataframe caching #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat of an overdue cleanup after getting a lot of the push-down filtering logic prototyped; it involved a lot more tracking of relationships between
display_idand other dataframe info than I initially expected, which meant there was a lot of abuse of global variables. It "worked" but wasn't clean and won't scale well, so this PR is going to fix at least the bulk of that.Going forward, we should be creating
DXDataFrameCacheobjects during the display format process, which will generatedisplay_idvalues and track original attributes of the data, while handling the cleaning and any sampling/truncating. When push-down filtering occurs, these objects should be referenced to get any necessary information and continue making associations between parent and child datasets.