Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS updates and some extra cleanup #34

Merged
merged 63 commits into from
Sep 20, 2022
Merged

OSS updates and some extra cleanup #34

merged 63 commits into from
Sep 20, 2022

Conversation

shouples
Copy link
Collaborator

@shouples shouples commented Sep 2, 2022

This probably should've been multiple PRs, but here we are.

Added

  • Github-published documentation
  • More github workflows

Changed

(mostly for ease of future development now that docs are being generated)

  • Directory restructure to move under src/dx and pull tests out into their own top-level directory
  • Renaming the formatters:
    • dx.formatters.dataresource -> dx.formatters.simple
    • dx.formatters.main -> dx.formatters.plain (dx.formatters.main now handles the main formatting flow)
    • dx.formatters.dx -> dx.formatters.enhanced
    • ...and all the test updates as a result of the above
  • Deduplication of code to consolidate main formatting functions under dx.formatters.main where main differences in formatting are either pulled from settings based on the current display mode, or are handled deep within generate_body() to change the structure of data before being sent to the frontend

Fixed

  • dx.display no longer gets mixed up with IPython.display
  • datetime.date or datetime.time values should be preprocessed and cast as strings before rendering
  • <dataframe>.groupby() rendering should no longer fail preprocessing

@shouples shouples changed the title OSS updates OSS updates and some extra cleanup/fixes Sep 19, 2022
@shouples shouples changed the title OSS updates and some extra cleanup/fixes OSS updates and some extra cleanup Sep 19, 2022
@shouples shouples self-assigned this Sep 20, 2022
@shouples shouples marked this pull request as ready for review September 20, 2022 20:16
@shouples shouples merged commit 3edff12 into main Sep 20, 2022
@shouples shouples deleted the djs/oss-updates branch September 20, 2022 20:16
@shouples shouples mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants