-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSS updates and some extra cleanup #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouples
changed the title
OSS updates and some extra cleanup/fixes
OSS updates and some extra cleanup
Sep 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably should've been multiple PRs, but here we are.
Added
Changed
(mostly for ease of future development now that docs are being generated)
src/dx
and pulltests
out into their own top-level directorydx.formatters.dataresource
->dx.formatters.simple
dx.formatters.main
->dx.formatters.plain
(dx.formatters.main
now handles the main formatting flow)dx.formatters.dx
->dx.formatters.enhanced
dx.formatters.main
where main differences in formatting are either pulled from settings based on the current display mode, or are handled deep withingenerate_body()
to change the structure ofdata
before being sent to the frontendFixed
dx.display
no longer gets mixed up withIPython.display
datetime.date
ordatetime.time
values should be preprocessed and cast as strings before rendering<dataframe>.groupby()
rendering should no longer fail preprocessing