Use "fixed" structure Real64 with recent versions of SML/NJ
#525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes MLton#523 Although SML/NJ 110.99.3 fixed some issues with `structure Real{,64}` failing to match the SML Basis Library specification, it did not implement `Real.fmt StringCvt.EXACT`. So, a "fixed" version of `structure Real64` needs to be exported (rather than exposing the version of `structure Real64` from `$/basis.cm`) and it is simplest to revert back to `structure Real64 = Real` (where `structure Real = FixReal(struct open Pervasive.Real end)`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #523
Although SML/NJ 110.99.3 fixed some issues with
structure Real{,64}failing to match the SML Basis Library specification, it did not implementReal.fmt StringCvt.EXACT. So, a "fixed" version ofstructure Real64needs to be exported (rather than exposing the version ofstructure Real64from$/basis.cm) and it is simplest to revert back tostructure Real64 = Real(wherestructure Real = FixReal(struct open Pervasive.Real end)).