Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate primitives from their hyperparameters dictionary #94

Closed
csala opened this issue Jul 11, 2019 · 0 comments · Fixed by #98
Closed

Isolate primitives from their hyperparameters dictionary #94

csala opened this issue Jul 11, 2019 · 0 comments · Fixed by #98
Assignees
Labels
internal improvement This introduces no noticeable changes in the behavior but improves code quality and performance
Milestone

Comments

@csala
Copy link
Contributor

csala commented Jul 11, 2019

The current implementation does not isolate the MLBlock hyperparameters dictionary from the underlying primitive, allowing this to modify its content and leading to unexpected behaviors and bugs.

This isolation should be enforced by using deepcopy instead of a simple copy when returning the hyperparameters in the get_hyperparameters method, and by always accessing the hyperparameters through this method instead of directly when passing them to the underlying primitive.

@csala csala added the internal improvement This introduces no noticeable changes in the behavior but improves code quality and performance label Jul 11, 2019
@csala csala added this to the 0.3.2 milestone Jul 11, 2019
@csala csala closed this as completed in #98 Jul 26, 2019
@csala csala self-assigned this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal improvement This introduces no noticeable changes in the behavior but improves code quality and performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant