Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling #176

Open
ehanson8 opened this issue May 17, 2024 · 2 comments
Open

Exception handling #176

ehanson8 opened this issue May 17, 2024 · 2 comments

Comments

@ehanson8
Copy link
Contributor

@ghukill comment in PR #175

  1. Does this have implications for DeletedRecordEvent? Do we want to update patterns so it has similar default, predictable behavior?
  2. Do we want more granular exception classes like InvalidRecordError that extend SkippedRecordEvent, such that we could raise those more meaningful, granular exceptions from code, but still have a single except SkippedRecordEvent: ... logic at the higher level to group skipping behavior for all those child Exception types?
@ehanson8 ehanson8 mentioned this issue May 17, 2024
9 tasks
@ehanson8
Copy link
Contributor Author

Add logging from exception to Transformer.__next__ method

@ghukill
Copy link
Contributor

ghukill commented May 23, 2024

Also noting that if a field method wants to skip a record, but these more granular exceptions don't feel right, there is nothing wrong with directly raising a SkippedRecordEvent with a meaningful message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants