Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Microsoft XML to JSON (tools) #95

Open
adulau opened this issue Mar 9, 2019 · 2 comments
Open

Fix Microsoft XML to JSON (tools) #95

adulau opened this issue Mar 9, 2019 · 2 comments
Labels

Comments

@adulau
Copy link
Member

adulau commented Mar 9, 2019

Fix Microsoft XML to JSON

@adulau adulau changed the title Fix Microsoft XML to JSON Fix Microsoft XML to JSON (tools) Mar 9, 2019
@adulau adulau added the bug label Mar 9, 2019
@kx499-zz
Copy link
Contributor

#96

Tackled it there, but had some questions about cidr and substring matches in the same list. The old one was set up that way and seemed to work so I'm not sure.

@adulau
Copy link
Member Author

adulau commented Mar 10, 2019

Good catch. I separated the generation into 2 warning-lists one for the CIDR block and the other for the string matching. It should be better but maybe some improvements could be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants