Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

例外クラス作成 #11

Merged
merged 1 commit into from
Sep 8, 2021
Merged

例外クラス作成 #11

merged 1 commit into from
Sep 8, 2021

Conversation

selfsryo
Copy link
Contributor

@selfsryo selfsryo commented Jul 3, 2021

概要

例外クラスを作成して統一

目的

呼び出し側でのエラーハンドリングを簡潔かつ明確にする

詳細

  • helper.pyでDemInputXmlException、DemOutputTiffExceptionという例外クラスを作成
  • 処理部分でExceptionを使っていた箇所を上記のクラスに変更

備考

  • QGISで動作確認済み
  • Pipfileのnumpyバージョン指定も変更

@selfsryo selfsryo requested a review from nokonoko1203 July 3, 2021 09:25
@selfsryo selfsryo linked an issue Jul 3, 2021 that may be closed by this pull request
[improve]Unity exception classes #9
Open
nokonoko1203
nokonoko1203 approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@nokonoko1203 nokonoko1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nokonoko1203 nokonoko1203 merged commit 141edef into develop Sep 8, 2021
@nokonoko1203 nokonoko1203 deleted the feature/MIERUNE-1928-unity-exception-class branch September 8, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nokonoko1203 nokonoko1203 nokonoko1203 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[improve]Unity exception classes
2 participants
@selfsryo @nokonoko1203