Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ascending T2*/S0 estimates #439

Closed
tsalo opened this issue Nov 10, 2019 · 0 comments · Fixed by #468
Closed

Drop ascending T2*/S0 estimates #439

tsalo opened this issue Nov 10, 2019 · 0 comments · Fixed by #468
Labels
refactoring issues proposing/requesting changes to the code which do not impact behavior T2*/S0 estimation issues related to the estimation of T2* and S0

Comments

@tsalo
Copy link
Member

tsalo commented Nov 10, 2019

Summary

We currently estimate T2* and S0 for all ascending subsets of echoes, starting at two. We then retain only those estimates associated with the value in the adaptive mask (except for voxels in the mask with a value of 1, where we use the T2*/S0 estimates from the first two echoes). This leads to a lot of calculations that are not used, as well as function outputs that no one wants. Also, while there is minimal time cost with the default log linear method, with the curve method calculating all of these unnecessary T2*/S0 estimates can take a while.

Additional Detail

We can limit T2*/S0 calculation to voxels and sets of echoes that will actually be used, as well as drop the ascending estimates from our outputs.

Next Steps

  1. Remove ascending T2*/S0 estimates from the outputs of fit_decay.
  2. Don't write out the ascending estimates when verbose is True.
  3. Remove the corresponding files from our list of outputs in the documentation, as well as the list of test outputs.
  4. Limit calculations (at least for curvefit) to only used voxels/sets of echoes.
@tsalo tsalo added T2*/S0 estimation issues related to the estimation of T2* and S0 refactoring issues proposing/requesting changes to the code which do not impact behavior labels Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring issues proposing/requesting changes to the code which do not impact behavior T2*/S0 estimation issues related to the estimation of T2* and S0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant