-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCD Module doesn't support Python 3 #659
Comments
See @arose 's comments on his work modifying the MDA DCD reader for simpetraj with Py3, in #260 (comment) . Update: sorry, saw that you already linked #260 and simpletraj... |
Ok, let me take a look. |
Note that with biophysics and other talks coming up I'm a bit inundated so progress here is quite slow lately. Do feel free to reassign the task if desired, otherwise I'll just occasionally chip away it. |
I've removed my assignment to this for now in case somebody else wants to step in. Otherwise, I will probably chip away at it slowly. |
I'll take it, but it won't be until November. If anybody else feels moved by the spirit before then, I'm happy to let them work on it. |
When I have some partially working cython up I'll push it to this repo instead of my fork. Then we can work together on it. I'm strongly in favor of a clean cython port because it will increase the maintainability of the code dramatically. |
Did you have a look at https://github.com/MDAnalysis/mdanalysis/blob/develop/package/MDAnalysis/coordinates/dcdtimeseries.pyx ? This is has a lot of cython code that shows how to use the VMD C code from “readdcd.h”. Of course, it is later patched into the DCD object https://github.com/MDAnalysis/mdanalysis/blob/develop/package/MDAnalysis/coordinates/DCD.py#L600 which relies on the code in https://github.com/MDAnalysis/mdanalysis/blob/develop/package/MDAnalysis/coordinates/src/dcd.c – the very thing that needs to be rewritten. Nevertheless, the reading of the trajectory in dcdtimeseries.pyx is independent from the reading in dcd.c so it should make for a useable starting point. Oliver Beckstein * [email protected] |
I've looked into that module. It is pretty old cython (rather pyrex) code that is close to the C-API of python. It's helpful but not as much as you would imagine. |
The DCD module doesn't currently support Python 3
Master py3 issue: #260
There's a py3 compatible version based on our version here:
https://github.com/arose/simpletraj/tree/master/simpletraj/dcd
So hopefully this will be simple
The text was updated successfully, but these errors were encountered: