-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDKit test failure #4813
Comments
I can reproduce it locally (macOS 15) with |
Reproducer: import rdkit.Chem as Chem
import MDAnalysis as mda
from io import StringIO
mol = Chem.MolFromSmiles("O=S(C)(C)=NC")
mol = Chem.AddHs(mol)
pdb = Chem.MolToPDBBlock(mol)
print(pdb)
u = mda.Universe(StringIO(pdb), format="PDB")
ag = u.select_atoms("all")
conf = Chem.Conformer(mol.GetNumAtoms())
for atom in mol.GetAtoms():
idx = atom.GetIdx()
xyz = ag.positions[idx].astype(float)
print(xyz)
conf.SetAtomPosition(idx, xyz)
mol.AddConformer(conf)
Chem.AssignStereochemistryFrom3D(mol) The positions are all zero in the PDB file, and therefore the same is true for the coordinates of the conformer. Something must have changed within |
@cbouy do you have any idea of what changed? Something definitely changed in RDKit, but I feel we are hitting an issue because we were relying on a bug/implementation detail of RDKit: the function |
RDKit test failures started to show up in CI:
A new version of RDKit landed a couple of days ago: https://github.com/rdkit/rdkit/releases.
The text was updated successfully, but these errors were encountered: