-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make biopython an optional dependency #3820
Comments
Ok with me. We can eventually replace it with something else (scikit-bio?) but perhaps also optional. In alignment (?) we use pairwise alignment somewhere, I don’t want to implement our own. Generic comment on optional packages: |
Honestly with the new 1.80 pin we need to have here, I feel like we should act on this sooner than later. Are there any objections for getting this done in 2.5.0? |
Both could load biopython on demand so we can definitely go ahead and make biopython an optional dependency. |
Btw, how do we declare that an optional dependency requires a minimal version number? |
Had a quick look with #4332 and it doesn't look like setuptools enforces a minimum version on biopython as an optional dep. This makes sense, the requirement is "optional", so it shouldn't be strongly opiniated about what's in your environment. As-is all our optional deps now don't have lower/upper pins on, which might not be the behaviour we want as a package. How do we want to go about this? One possible suggestion here is to spruce up our optional importers to also have version validators? That shouldn't be too hard to do. |
I think this has been a long time request by @jbarnoud (apologies if I'm misremembering).
Not the biggest dependency, but we could easily make it an optional one given we need it mostly for sequence alignment. Probably needs some discussion re: the impact it has on seqres though.
The text was updated successfully, but these errors were encountered: