Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace atoms.coordinates() with atoms.positions in benchmarks #3638

Closed
orbeckst opened this issue Apr 14, 2022 · 3 comments · Fixed by #3668
Closed

replace atoms.coordinates() with atoms.positions in benchmarks #3638

orbeckst opened this issue Apr 14, 2022 · 3 comments · Fixed by #3668
Labels
benchmarks performance benchmarking with ASV defect good-first-issue

Comments

@orbeckst
Copy link
Member

Expected behavior

Benchmarks run with latest release.

Actual behavior

Some benchmarks use outdated and removed AtomGroup.coordinates() instead of AtomGroup.positions.

Code to reproduce the behavior

Output from git grep 'coordinates() for the benchmarks:

benchmarks/benchmarks/analysis/rms.py:        # ag.coordinates()
benchmarks/benchmarks/analysis/rms.py:            self.A = self.u.atoms.coordinates().copy()[:num_atoms]
benchmarks/benchmarks/analysis/rms.py:            self.B = self.u.atoms.coordinates().copy()[:num_atoms]

(Follow-up from #3467 )

Current version of MDAnalysis

  • Which version are you using? (run python -c "import MDAnalysis as mda; print(mda.__version__)") develop 2.2.0
@orbeckst orbeckst added defect benchmarks performance benchmarking with ASV good-first-issue labels Apr 14, 2022
@orbeckst
Copy link
Member Author

See https://github.com/MDAnalysis/benchmarks for the benchmark repo with the README giving an introduction on how to run ASV locally.

The benchmarks wiki also has some notes.

@aditi2906
Copy link
Contributor

@orbeckst I want to work on this issue.. However, the readme of benchmarks repo
does not give a good headstart on how to run asv locally. Can you help me with it.
Thankyou

@orbeckst
Copy link
Member Author

Please see https://github.com/MDAnalysis/mdanalysis/blob/develop/benchmarks/README.rst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks performance benchmarking with ASV defect good-first-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants