Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py3 TODO comments in core.Universe #2921

Closed
IAlibay opened this issue Aug 27, 2020 · 2 comments · Fixed by #2923
Closed

Py3 TODO comments in core.Universe #2921

IAlibay opened this issue Aug 27, 2020 · 2 comments · Fixed by #2923
Milestone

Comments

@IAlibay
Copy link
Member

IAlibay commented Aug 27, 2020

Just having a look through core.Universe and I'm noticing there's a lot of comments tagged as "Py3 TODO"
e.g.

# py3 TODO
#def _resolve_formats(*coordinates, format=None, topology_format=None):

It's unclear to me what are intended by these, but now that we are solely py3+ we should either implement them or remove the comments?

@richardjgowers
Copy link
Member

It might be argument unpacking changes that are py3 specific. I think you previously couldn't have named kwargs after a variable length list of args. I think when @lilyminium was reworking Universe creation she ran into this a bit if you want to find the PR

@IAlibay
Copy link
Member Author

IAlibay commented Aug 27, 2020

I see, this is related to #2322, I don't think there's another opened issue for this, so I'll add it to the 2.0 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants