Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for ENCORE needs to be increased #29

Open
jbarnoud opened this issue Feb 17, 2022 · 4 comments
Open

Test coverage for ENCORE needs to be increased #29

jbarnoud opened this issue Feb 17, 2022 · 4 comments
Labels
tests Improvements or fixes to the tests.

Comments

@jbarnoud
Copy link

Expected behavior

Analysis code base is covered with test, including ENCORE.

Actual behavior

Some of ENCORE's untested code appear to be dead code. See MDAnalysis/mdanalysis#3479 (comment)

Ping @mtiberti and @wouterboomsma

@IAlibay IAlibay transferred this issue from MDAnalysis/mdanalysis Sep 6, 2023
@wouterboomsma
Copy link

@jbarnoud, I'm trying to get an overview over outstanding issues in Encore (we're looking into finding a new maintainer for the code). Do you know if this current issue is still relevant or was it solved by MDAnalysis/mdanalysis#3621?

@IAlibay
Copy link
Member

IAlibay commented Sep 11, 2023

@wouterboomsma would you be happy to have a call with the MDA coredevs to discuss this further at some point? We would definitely love to have someone come here and help maintain encore.

We can probably also explain the current move towards mdaencore and how it falls without our commitments to develop an ecosystem of downstream tools

@wouterboomsma
Copy link

Yes. That would be great, thanks. We'll contact all the original authors of the ENCORE paper for a meeting. If possible, it would be great if one or more of the MDA coredevs could briefly join in and explain the vision for the downstream tool ecosystem. Shall I reach out through email?

@IAlibay
Copy link
Member

IAlibay commented Sep 12, 2023

Yes. That would be great, thanks. We'll contact all the original authors of the ENCORE paper for a meeting. If possible, it would be great if one or more of the MDA coredevs could briefly join in and explain the vision for the downstream tool ecosystem. Shall I reach out through email?

If you can reach out to [email protected] it will go out to all the coredevs so we can make sure at least one of us can join in.

@orbeckst orbeckst added the tests Improvements or fixes to the tests. label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Improvements or fixes to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants