Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

Todo for 2.0.1 (Big update, comment features requests & issues!!!) #10

Closed
45 of 53 tasks
DaPigGuy opened this issue Oct 9, 2016 · 57 comments
Closed
45 of 53 tasks
Assignees

Comments

@DaPigGuy
Copy link
Collaborator

DaPigGuy commented Oct 9, 2016

Features/Tweaks

  • Checks if player trying to connect has same uuid as current player with same name
  • Hides items til authenticated
  • Save data in player.dat
  • Password Filter
  • Capes for registered players.
  • VIP Slots?
  • Make xbox bypass compatible with PMMP
  • Allow players to give other players temp keys to login to their account that expire after certain amount of time?
  • Add MailGun support
  • More configurable
  • Events for developers
  • Progress Reports
  • Choose what events to block
  • Different join message for new players
  • Block join messages til logged in
  • Keys! 🔑
  • Boss bar messages
  • Preregister
  • Adventure mode til logged in
  • Hide players til logged in
  • Hide health (and stop from healing), xp (and stop from getting xp), potion effects (and stop potion effects too)
  • Return to spawn when logged in
  • Block accounts in block list from registering/logging in
  • Only show the attempted login if there was one.
  • Show different authenticated message for users logged in by uuid or xbox bypass
  • Email verification
  • Floating text
  • Message of the day w/ command
  • Account lockdown (locks account if there have been too much login attempts) until unlocked with pin.
  • Stop pins for certain users.
  • Wait til email to stop effects, event cancel, etc.
  • Block usernames as passwords
  • Async
  • New config
  • Hashing cost
  • Transfer players when full
  • Allow bypassing login on other accounts (like steve bypass)
  • Unregister
  • Allow head movement
  • Email when logged in from new ip
  • Multi lang support

Issues

  • Xbox bypass not working
  • Blindness & invisibility are given even if disabled
  • Crashing for sqlite3 users
  • If you logout after you login, you get kicked from previous timeout task 😑
  • Fix error if quit before login.
  • Fix big problem when server is reloaded.
  • Fix errors caused by Slapper.
  • Fix error with adventure mode
  • Fix hunger at 0 after dying.
  • Fix register message not showing unless logged in by xbox live
  • Fix confirm password message
  • Email Server
@DaPigGuy DaPigGuy added the todo label Oct 9, 2016
This was referenced Oct 9, 2016
@DaPigGuy DaPigGuy changed the title Todo for 2.0.1 (Big update, sugguest features!!!) Todo for 2.0.1 (Big update, comment features requests & issues!!!) Oct 9, 2016
@DaPigGuy DaPigGuy self-assigned this Oct 9, 2016
@fycarman
Copy link

Serverauth to piggyauth importer! :)

@Aericio
Copy link
Collaborator

Aericio commented Nov 5, 2016

Block people from registering/logging in with explicit names.

@DaPigGuy
Copy link
Collaborator Author

DaPigGuy commented Nov 7, 2016

@Aericio Okay, added to to-do list.

@Aericio
Copy link
Collaborator

Aericio commented Nov 9, 2016

Only show "There has been (X) attempts to login into your account" if someone has tried to login so it doesn't always show on login.

@DaPigGuy
Copy link
Collaborator Author

Added to to-do list.

@Aericio
Copy link
Collaborator

Aericio commented Nov 11, 2016

Allow option to disable pin for certain players. For example, if owner's pin is found out, there goes your whole server. Don't got a backup? Your dead.

@NyaomiDEV
Copy link

@MCPEPIG WE WANT MORE BACON

@Adam1609
Copy link

SimpleAuthTransfer to PiggyAuth? Would be possible?

@DaPigGuy
Copy link
Collaborator Author

I think converting isnt needed as password_verify also does SHA256 and thats what simpleauth uses.

@DaPigGuy
Copy link
Collaborator Author

@aerico Added.

@DaPigGuy
Copy link
Collaborator Author

Will work on this later.

@DaPigGuy
Copy link
Collaborator Author

Update to the latest version to stop the errors!

@DaPigGuy
Copy link
Collaborator Author

Update to the latest version. Fixes a very bad issue & also fixes incompatibility issues for Genisys users.

@ghost
Copy link

ghost commented Nov 13, 2016

Hi, I expect MD5 support.

@DaPigGuy
Copy link
Collaborator Author

@Harviy MD5 is bad.

@Aericio
Copy link
Collaborator

Aericio commented Nov 19, 2016

Check if the user's password is the same as the username.

@SuperKali
Copy link

SuperKali commented Nov 19, 2016

cattura41
bug

when I died the food not from

@Aericio
Copy link
Collaborator

Aericio commented Nov 19, 2016

When you die, your food doesn't go back?

@SuperKali
Copy link

@Aericio
Yes
Another bug What I noticed and that if the player enters, does not find anything in the inventory

@DaPigGuy
Copy link
Collaborator Author

That's not a bug, it's an option which hides inventory til logged in. You can turn it off in config.

@DaPigGuy
Copy link
Collaborator Author

Fixed the problem with hunger.

@DaPigGuy
Copy link
Collaborator Author

@aerico Done.

@Aericio
Copy link
Collaborator

Aericio commented Dec 24, 2016

Make an option to force certain people to login with Xbox. Extra security for server owners or OPs

@Thunder33345
Copy link
Contributor

proposal: regex blocking for name and password
proposal: more then steve bypass, allows owner to configure accounts to be bypassed
proposal: a more hierarchy config like https://github.com/PEMapModder/HereAuth/blob/master/resources/config.yml allows user to easily navigate

@DaPigGuy
Copy link
Collaborator Author

1 & 2 I will do, 3 I might add in the next update.

@Thunder33345
Copy link
Contributor

Save data in player.dat

What does that means? i dont think injecting hashing data into player.dat is a good idea, at least a toggle option would be prefered

also you should create a usage wiki this plugin is getting quite big with a lot of features and so on

@DaPigGuy
Copy link
Collaborator Author

Save hashed passwords & stuff

@DaPigGuy
Copy link
Collaborator Author

I've added a MailGun & database page. What else? Also, you can contribute to it.

@Aericio
Copy link
Collaborator

Aericio commented Mar 10, 2017

I made the wiki sexier :3

@Aericio
Copy link
Collaborator

Aericio commented Mar 10, 2017

FEATURE REQUEST: If someone LOGS IN to someone's account from a new ip address, send an email to tell them that someone has logged in, not ATTEMPTED (unless you want it like that too, but this is kinda like what most people do, ex: twitter)

@Thunder33345
Copy link
Contributor

as for saving hashes into player.dat, i still fail to see why that would been better?

maybe we are getting too ahead of our self but, option to toggle email and toggle per notification settings

@DaPigGuy
Copy link
Collaborator Author

I'll add a toggle for email later. And notifications as in emails?

@Thunder33345
Copy link
Contributor

i also tried to implement regex support which ended up with a flop on unexpected logic error(which i intended it to be regex white list 🤦)
main question is accidentally reformatted the whole code to my own code style (derp)
https://github.com/Thunder33345/PiggyAuth/commit/f0c35ec288f1771677c14ca2afee55d71946662c
do i need to redone or your ide is capable to reformatting it back into your code style when we merge, or github will sort it for us?

@DaPigGuy
Copy link
Collaborator Author

Reformat

@ghost
Copy link

ghost commented Mar 11, 2017

Add something like if player is not registered or logged in, it gets random username, for example Player1, Player2, etc. and it can do everything like normal player but it will not can execute commands? I hope I was clear enough. (Like on LBSG.)

@ghost
Copy link

ghost commented Mar 12, 2017

Thanks Aericio.

@Aericio Aericio mentioned this issue Mar 13, 2017
@Aericio
Copy link
Collaborator

Aericio commented Mar 14, 2017

causes chat to lag when used on TesserREKT.

@ghost
Copy link

ghost commented Mar 14, 2017

On pmmp (PocketMine-MP) too.

@DaPigGuy
Copy link
Collaborator Author

Temporarily fixed. Need a way to add back password checking for messages without lag.

@ghost
Copy link

ghost commented Mar 15, 2017

:/

@SleepSpace9
Copy link
Contributor

Because pmmp has no core feature for banning CIDs (and Genisys is discontinued) maybe this could be a new feature of PiggyAuth. By the way I don't know whether somebody already did a request for that at pmmp.

@Thunder33345
Copy link
Contributor

what feature?

@SleepSpace9
Copy link
Contributor

Banning ClientIDs

@Aericio
Copy link
Collaborator

Aericio commented Mar 29, 2017

Why exactly would an auth plugin need a banning system though..?

@Thunder33345
Copy link
Contributor

i think this shouldnt be tied into a auth plugin

@Aericio
Copy link
Collaborator

Aericio commented Mar 29, 2017

Other plugins have been made to ban CIDs, you could use those instead.

@SleepSpace9
Copy link
Contributor

Well I don't like too many plugins with dozens of listeners and thought an auth plugin would be a good place for this little feature.
But never mind, I also understand your opinion. I guess most advanced server owners do already have an extra plugin for banning.

@Thunder33345
Copy link
Contributor

mostly we need separations to keep our plugin doing only what we are doing
also dozens of plugins dosent impact anything if these dozens of plugin does nothing
it depends on what kind of plugin and what it does that's the factor that how much performance it impacts

@Aericio
Copy link
Collaborator

Aericio commented Mar 30, 2017

if the plugin cannot connect to mysql server, turn on whitelist.

@DaPigGuy
Copy link
Collaborator Author

DaPigGuy commented Apr 1, 2017

It has been decided that we should move on to 3.0.0. The current features that haven't been done will be moved to 3.0.0 todo. 3.0.0 will be a big rewrite.

@DaPigGuy DaPigGuy closed this as completed Apr 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants