Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Link-Time Optimization (LTO) #535

Open
zamazan4ik opened this issue Oct 8, 2024 · 1 comment
Open

Enable Link-Time Optimization (LTO) #535

zamazan4ik opened this issue Oct 8, 2024 · 1 comment

Comments

@zamazan4ik
Copy link

Is your feature request related to a problem? Please describe.
Not a problem - just a performance improvement idea.

Describe the solution you'd like
I noticed that in the Cargo.toml files Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. E.g., check cargo-outdated Release profile.

Basically, it can be enabled with the following lines:

[profile.release]
lto = true

I also found this comment in discussions with an LTO mention.

Describe alternatives you've considered
Leave things as is

Additional context
N/A

@kauri-hero
Copy link
Contributor

Thanks for your input and interest in the project!

Will discuss with devs and triage this
CC: @dnwiebe @bertllll @czarte

@github-project-automation github-project-automation bot moved this to 🆕 New in MASQ Node v2 Oct 9, 2024
@kauri-hero kauri-hero moved this from 🆕 New to 🔖 Awaiting Development (Prioritized) in MASQ Node v2 Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Awaiting Development (Prioritized)
Development

No branches or pull requests

2 participants