Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate --min-hops with PersistentConfiguration #691

Closed
utkarshg6 opened this issue Apr 6, 2023 · 1 comment · Fixed by MASQ-Project/Node#294
Closed

Integrate --min-hops with PersistentConfiguration #691

utkarshg6 opened this issue Apr 6, 2023 · 1 comment · Fixed by MASQ-Project/Node#294
Assignees
Labels
hardenning Getting a feature working stronger

Comments

@utkarshg6
Copy link

This card is a child of #567 and is blocked by #690.

Make a place for it in PersistentConfiguration and modify SetupReporter to load it from the database if it isn't specified anywhere with higher priority. Remember to add a database migration for the new configuration property and bump the CURRENT_SCHEMA_VERSION constant.

@utkarshg6 utkarshg6 self-assigned this May 26, 2023
@utkarshg6 utkarshg6 added the hardenning Getting a feature working stronger label May 26, 2023
@utkarshg6
Copy link
Author

utkarshg6 commented Jun 22, 2023

Testing Outline

Log Level: Trace

  1. Test Case 1: Default Value

    • Start the Node (a new Node Installation) without providing any value for --min-hops.
    • Check the Database to verify if the default value of 3 has been saved.
    • Browse the internet and share the logs for this case.
  2. Test Case 2: Custom Value

    • Start the Node with a smaller value for --min-hops, e.g., 1 or 2.
    • Check the Database to confirm whether the provided value has been saved.
    • Join the network and transfer some data.
    • Browse the internet and share the logs for this case.
  3. Test Case 3: Use Database Value

    • Start the Node (continuing from the test case 2) without providing any value for --min-hops.
    • Make sure even though you didn't provide any value with the parameter, the value stays the same that you've set in the previous test case.
    • Browse the internet and share the logs for this case.

Here's the way to check the database configuration:

  • Run the node with the desired args, for example:
sudo MASQNode --ip 1.2.3.4 --min-hops 2
  • Kill the command's execution using `Ctrl + C.

  • Use --dump-config to see the database configuration

MASQNode --dump-config
  • You'll see an output like this on the terminal screen
{
"blockchainServiceUrl": null,
"chainName": "polygon-mainnet",
"clandestinePort": "7184",
"consumingWalletPrivateKey": null,
"earningWalletAddress": null,
"exampleEncrypted": null,
"gasPrice": "1",
"mappingProtocol": null,
"minHopsCount": "2",
"neighborhoodMode": "standard",
"pastNeighbors": null,
"paymentThresholds": "1000000000|1200|1200|500000000|21600|500000000",
"ratePack": "172300000|1723000000|344600000|3446000000",
"scanIntervals": "600|600|600",
"schemaVersion": "8",
"startBlock": "14863650"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardenning Getting a feature working stronger
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant