Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Dependencies #128

Open
wildintellect opened this issue Dec 20, 2023 · 3 comments
Open

Refactor Dependencies #128

wildintellect opened this issue Dec 20, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@wildintellect
Copy link
Collaborator

  • stac ipyleaflet version: 0.3.6

Description

In order to make stac_ipyleaflet widely compatible with many containerized images, we need to be stricter about not pulling in large dependencies. https://github.com/MAAP-Project/stac_ipyleaflet/blob/main/requirements.txt needs to be revisited to clean up unused library imports.

Example: Xarray and rio_tiler appear to only be used for the commented out sections following

""" def gen_mosaic_dataset_reader(self, assets, bounds):

If we can avoid Xarray as a dependency that would be good.

An alternative would be to make optional dependencies. Features that are only available if dependencies are installed.

@wildintellect wildintellect added the enhancement New feature or request label Dec 20, 2023
@wildintellect
Copy link
Collaborator Author

@anilnatha until this is solved looks like we should only use stac_ipyleaflet in pangeo based workspaces that already include Xarray.

@emmalu
Copy link
Collaborator

emmalu commented Dec 20, 2023

My initial thoughts on what can be removed:

  • localtileserver, since we opted to use an already-running version of titiler
  • requests because any remaining requests calls could be replaced with pystac_client methods
  • xarray because the histogram feature it's for is not active at the moment

@anilnatha
Copy link

anilnatha commented Dec 20, 2023

I noticed the project has a requirements.txt file and dependencies are also listed in the setup.cfg file, if these could be consolidated to the setup.cfg it may make it easier to maintain the dependency list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants