Pro license should not be readable by all apps but just XPrivacy

[amishmm]

As reported by kaizokan (XDA user), I am creating an issue.

http://forum.xda-developers.com/showthread.php?p=45818936

Pro license file should not be stored in /sdcard (because it has privacy related information)

Suggested solution:

1. Have import license button
2. After import it can be stored in say /data/xprivacy/ (optionally delete file from sdcard after import)
3. Change owner and group of /data/xprivacy to that of XPrivacy app itself.
4. XPrivacy should look for it in /data/xprivacy/ instead of (or in addition to) /sdcard
5. (Optional) If valid license exists in /sdcard/ (but not in /data/xprivacy) then it may prompt user to import and then delete it.

Thanks.

[M66B]

Storing the license file in data would mean it would get wiped when uninstalling XPrivacy or when wiping data, so IMHO this is not a good idea.

See also issue #703

[amishmm]

Sorry about not noticing already existing issue. I did check if issue was already there. But possibly overlooked its existence. (Or may be git cache did not show it somehow)

Well if user uninstalls it, that means he no more wants to use XPrivacy (or temporarily does not want it)

Plus it would not be tough to re-import it.

[kohanla]

I agree completely. After I noticed it contains private information it actually stopped me from buying licenses for my friends ("gift").

In addition, M66B should change the format to something that contains a serial number only he can identify IMHO.

I bought a license, but I am not using it for this exact reason (but I am not "angry" since I mainly purchased it to donate and support this fantastic project).