Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Changed settings dialog to an activity #1938

Merged
merged 14 commits into from
Aug 30, 2014
Merged

Conversation

tonymanou
Copy link
Contributor

This changes the settings dialog to an activity.
This removes the issue with the outdated title bar as well as a glitch in popup's white theme.

settings

There are quite a lot of lines changed but I divided the changes into multiple commits, thankfully it will be easier to follow them.

@M66B
Copy link
Owner

M66B commented Aug 28, 2014

I have only a phone with me, so it is difficult to read sources for me at this moment, but I am wondering if you took care of updating the main and details view too, like the on demand check box of the details view.

I will wait with merging this until after releasing a new stable version in any case.

I am glad you are contributing again!

@tonymanou
Copy link
Contributor Author

These changes are only for the settings dialog (main settings and app settings), I did not touch the detail view (yet 😉).

but I am wondering if you took care of updating the main and details view too, like the on demand check box of the details view

I don't understand... Do you think I should update the main and details views too?

As you want for the merge, it could have been a nice feature to add to the last XPrivacy 2 release!

@M66B
Copy link
Owner

M66B commented Aug 28, 2014

What I mean is that some settings changes have effect in the main and details view, for example enabling or disabling on demand restricting.

@M66B
Copy link
Owner

M66B commented Aug 28, 2014

Everything looks okay, also the refresh of the application list and application details view:
https://github.com/M66B/XPrivacy/pull/1938/files#diff-79934cfdf441be9ed6da5678e57d3ee2R759

@tonymanou
Copy link
Contributor Author

I just checked and it's alright: enabling/disabling on demand restricting updates the main/details view when you save the settings.

M66B added a commit that referenced this pull request Aug 30, 2014
Changed settings dialog to an activity
@M66B M66B merged commit 3aad666 into M66B:master Aug 30, 2014
M66B added a commit that referenced this pull request Aug 30, 2014
Showing action bar items always
Remove passing application name
Formatting

Refs #1938
@M66B
Copy link
Owner

M66B commented Aug 30, 2014

This is all good work, Tony!

@tonymanou
Copy link
Contributor Author

Thanks, I'm happy to contribute!

@tonymanou tonymanou deleted the settings_activity branch August 30, 2014 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants