Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Select contact pictures to allow #1588

Closed
geileszeuch opened this issue Mar 19, 2014 · 14 comments
Closed

Select contact pictures to allow #1588

geileszeuch opened this issue Mar 19, 2014 · 14 comments

Comments

@geileszeuch
Copy link

At the moment apps do not show the small contact pictures, even if one allows the contact for this app. (You can check this in the messaging app for example)

I would suggest to add an extra checkbox in the 'Select contacts to allow' menu next to contacts which you have allowed. Checking this box will allow the user picture for the app. Unchecking it will just give the default picture.

@M66B
Copy link
Owner

M66B commented Mar 19, 2014

Which messaging app do you mean? Please mention the package name. I also like to see a logcat.

@geileszeuch
Copy link
Author

I was talking about the default Android messaging app com.android.mms. I do not know why you want a logcat. I was not reporting a bug. This is a feature suggestion. This happens in every app which shows user pictures/avatars which you have set in androids default 'People' app com.android.contacts.

How to reproduce:

  1. set an avatar for a contact you have in com.android.contacts
  2. restrict the category 'Contacts' completely for the default messaging app com.android.mms
  3. allow the contact you used in 1. for the messaging app com.android.mms
  4. open the messaging app and press the new message button and now press the '+' sign next to the receiver field to add receivers. Now you can see all your contacts you allowed for the messaging app with small avatars on the left. Although the contacts are allowed one can not see the real avatar in the small version. If you press on an avatar the big version of it will come up, which is now the real avatar you set in 1. (Small avatar is not shown, big one is shown when pressing on the small one)

This can alternatively be made with any app that uses those small avatars.

@M66B
Copy link
Owner

M66B commented Mar 19, 2014

I will see what I can do, but it may not be possible to fix this.
The logcat would be useful to see which restriction causes the images not to show.

@geileszeuch
Copy link
Author

I can tell you that. It is contacts/contacts in the category Contacts.

@M66B
Copy link
Owner

M66B commented Mar 19, 2014

I am quite sure allowing for this restriction works, but to be sure I need to see a logcat. Are there any other restrictions in the contacts category touched?

@geileszeuch
Copy link
Author

No, you can set all other restrictions in the contacts category as long as contacts/contacts is not restricted the avatars are shown.

And also if all others are not restricted and contacts/contacts is, then the avatars are not shown.

@M66B
Copy link
Owner

M66B commented Mar 20, 2014

I don't have the default Android messaging app com.android.mms, so I need to see a logcat to see what is going on.

@M66B
Copy link
Owner

M66B commented Mar 20, 2014

For Hangouts, the new default Android contacts application, this works okay, the icons for allowed contacts are shown.

@M66B
Copy link
Owner

M66B commented Mar 20, 2014

Which XPrivacy version are you using?

@geileszeuch
Copy link
Author

This also happens with com.android.email if you read a mail to/from one of your allowed contacts with an avatar. I cannot provide a logcat at the moment. Sorry for that.

I am using XPrivacy v. 2.0.4 (311).

@M66B
Copy link
Owner

M66B commented Mar 20, 2014

I don't have that package either.

@geileszeuch
Copy link
Author

Other apps which have the same behaviour:

  • Kontalk (org.kontalk)
  • Redphone (org.thoughtcrime.redphone)

@M66B M66B closed this as completed in 1229f00 Mar 20, 2014
@M66B
Copy link
Owner

M66B commented Mar 20, 2014

It should be fixed in this test version: http://d-h.st/Qmi
Please let me know if it is and if there are no side effects (also not in other applications).

@geileszeuch
Copy link
Author

Seems to work fine, haven't found any side effects yet. Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants