Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Differences btwn "Clear All" and clearing a restriction category #1198

Closed
wbedard opened this issue Jan 29, 2014 · 13 comments
Closed

Differences btwn "Clear All" and clearing a restriction category #1198

wbedard opened this issue Jan 29, 2014 · 13 comments
Labels

Comments

@wbedard
Copy link

wbedard commented Jan 29, 2014

This may be a feature or a bug. However, with the new Enable/Disable Restrictions toggle for each app, I think it should be a bug.

Currently, if I clear a category restriction (I.e. IPC in my case) and then restrict it again, not all the restrictions are checked. Since none are marked as Dangerous, they must be indicated as exceptions in the database. If I have All selected in the category filter and clear the app, I can then select a category and all its restrictions will be selected because all the exceptions were wiped in the Clear All operation.

Before the new restrictions toggle, which allows one to unrestrict an app while still preserving all the app's restriction settings, this behavior of clearing out exceptions only during a Clear All operation made sense. However, with the new toggle, I believe that clearing a restriction category should now clear all its exceptions, too, without having to completely wipe an app's restrictions.

What do you think?

@jpeg729
Copy link
Contributor

jpeg729 commented Jan 29, 2014

Personally I would welcome the change because I always found that more of a nuisance than a help.

@wbedard
Copy link
Author

wbedard commented Jan 29, 2014

As usual, I completely agree!

@M66B
Copy link
Owner

M66B commented Jan 31, 2014

The IPC functions where before dangerous, but not anymore.

I have to chose here between losing your maybe carefully set functions exception by toggle the restriction category or clearing/setting the function exceptions by toggling the restriction category. Both have advantages and disadvantages. For now I have chosen to do the first.

@M66B
Copy link
Owner

M66B commented Feb 2, 2014

My proposal is to add a long click to clear the category, either in the main view when a category is selected and/or in the app details view for each category.

@wbedard
Copy link
Author

wbedard commented Feb 2, 2014

Well, you certainly don't need me to confirm how "onboard" I am with this idea...:>). Thank you for giving the idea your consideration.

@M66B
Copy link
Owner

M66B commented Feb 3, 2014

Another more transparent solution than a long click would be a choice, like the template, which pops up when selecting 'Clear' in the application details view menu. This can replace the current 'Are you sure' dialog.

@jpeg729 also for this a pull request would be very welcome, but take your time.

@jpeg729
Copy link
Contributor

jpeg729 commented Feb 3, 2014

Something like -
Title: Clear categoryName
Msg: Should the exceptions be cleared to?
Buttons: Remember & Clear

@M66B
Copy link
Owner

M66B commented Feb 3, 2014

I meant a dialog like the template definition dialog.

@wbedard
Copy link
Author

wbedard commented Feb 3, 2014

Perhaps I'm behind a few too many versions of XP but it isn't vividly clear what the implementation would look like to the user based on the descriptions presented. Jpeg's were the clearest in terms of presentation but perhaps we both are unclear where/how such a choice would be triggered.

Any effort to "hand-hold" the slow-witted would be greatly appreciated!

@jpeg729
Copy link
Contributor

jpeg729 commented Feb 3, 2014

How about when you click on a category checkbox to clear it seeing the usual Are you sure? with an additional checkbox "Forget exceptions" that is unchecked by default?

That might be the simplest idea possible.

@M66B
Copy link
Owner

M66B commented Feb 3, 2014

That is perfectly fine with me.

@wbedard
Copy link
Author

wbedard commented Feb 3, 2014

That sounds perfect to me!

@M66B M66B closed this as completed in dd399e7 Feb 4, 2014
@banderos101
Copy link

me three

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants