Batch fetch fetches system apps

[vanowm]

I think it's quiet important bug when you see list of apps filtered the way you like and want fetch permissions for these apps, only to realize that permissions for all other apps, including system getting destroyed in the process and you can't stop it...

[M66B]

Duplicate of #1031

Restrictions are only cleared for applications found on the server. Restrictions for system applications can only be fetch individually.

[vanowm]

Well then it's a bug and not a feature request with a low priority, because system apps got their permissions changed when I did fetch for non-system apps (or so I thought...)

[M66B]

System applications are not batch fetched, I have checked:
https://github.com/M66B/XPrivacy/blob/master/src/biz/bokhorst/xprivacy/ActivityShare.java#L528

[vanowm]

I cleared all permissions, made sure both user and system apps are cleared, switched to user apps view and selected fetch permissions from menu. The result:

Either I'm doing something wrong or it's a bug?

[vanowm]

Then I looked at the line you showed and it's clearly a bug because the statement is true if app not system OR data not empty. It should be "AND"

[M66B]

It should be an OR: not system application OR individual fetch.
Nevertheless I will test this later again.