Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image loading blocking UI #78

Open
nselvapandian opened this issue Dec 28, 2018 · 2 comments
Open

Image loading blocking UI #78

nselvapandian opened this issue Dec 28, 2018 · 2 comments

Comments

@nselvapandian
Copy link

nselvapandian commented Dec 28, 2018

While rendering big size image, app got freezed because it's blocked the UI. It is possible to render images in background without blocking the UI?

@georgbachmann
Copy link

Just had the exact same problem. App freezes quite some time...
And in the mean-time. Is there a way to disable inline images? (Better not showing them than having the app freeze)

@Basca
Copy link
Contributor

Basca commented Jan 21, 2019

Hey nselvapandian and georgbachmann,

We are aware of rendering that can block UI for the inline images and are still looking for a good way to fix the issue. Feel free to look into the issue and share your thoughts on how we can improve it.

In the meantime, you can actually remove/replace the InlineImageAttributedStringBlockBuilder by creating your own subclass of MarkDownConverterConfiguration and passing that to the MarkDownConverter.
An example of how you can pass your own configuration can be found in AdvancedMarkdownViewController

In short:

        let configuration = <your custom subclass>
       let converter = MarkDownConverter(configuration: configuration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants