From ce76d99f73973aca9fd1b0ab5ffe9b975ff71857 Mon Sep 17 00:00:00 2001 From: James Cuzella Date: Tue, 16 Jul 2024 20:05:33 -0600 Subject: [PATCH] bootstrap.sh: Fix more SC2086 warnings Just quote the things Shellcheck warnings were: In bootstrap-scripts/bootstrap.sh line 128: kill -TERM $timeout_loop_PID ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill -TERM "$timeout_loop_PID" In bootstrap-scripts/bootstrap.sh line 185: rustup default stable-${machine}-apple-darwin ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rustup default stable-"${machine}"-apple-darwin --- bootstrap-scripts/bootstrap.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bootstrap-scripts/bootstrap.sh b/bootstrap-scripts/bootstrap.sh index d8848ac3..722a2588 100755 --- a/bootstrap-scripts/bootstrap.sh +++ b/bootstrap-scripts/bootstrap.sh @@ -125,7 +125,7 @@ prevent_sudo_timeout() { # shellcheck disable=SC2317 kill_timeout_loop() { echo "Killing $timeout_loop_PID due to trap" - kill -TERM $timeout_loop_PID + kill -TERM "$timeout_loop_PID" sudo -K } trap kill_timeout_loop EXIT HUP TSTP QUIT SEGV TERM INT ABRT # trap all common terminate signals @@ -182,7 +182,7 @@ function rvm_set_compile_opts() { if [[ "$RVM_ENABLE_YJIT" == "1" ]]; then CONFIGURE_ARGS="${CONFIGURE_ARGS} --enable-yjit" - rustup default stable-${machine}-apple-darwin + rustup default "stable-${machine}-apple-darwin" fi if [[ "$RVM_WITH_JEMALLOC" == "1" ]]; then CONFIGURE_ARGS="${CONFIGURE_ARGS} --with-jemalloc"