From d5f7a64344f8f6b3439556e0d6230cfbcbfdd60b Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Sat, 17 Feb 2024 14:30:42 +0100 Subject: [PATCH] build: Remove redundant linking of libcaesium This is already done by `add_dependencies` --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index d1b7de7d..44d471be 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -218,7 +218,7 @@ else () LOG_BUILD ON BUILD_BYPRODUCTS ${LIBCAESIUM_EXTERNAL_PATH} ) - add_dependencies(caesium_image_compressor libcaesium) + add_dependencies(${TARGET} libcaesium) endif () # --- WinSparkle --- @@ -249,7 +249,7 @@ elseif (WIN32) target_link_libraries(${TARGET} PRIVATE Qt${QT_VERSION_MAJOR}::Widgets Qt${QT_VERSION_MAJOR}::Core Qt${QT_VERSION_MAJOR}::Gui Qt${QT_VERSION_MAJOR}::Concurrent Qt${QT_VERSION_MAJOR}::Svg Qt${QT_VERSION_MAJOR}::Network Qt${QT_VERSION_MAJOR}::Sql winsparkle ${LIBCAESIUM_SOURCE_DIR}/target/x86_64-pc-windows-gnu/${LIBCAESIUM_BUILD_TYPE}/caesium.dll) else () set_target_properties(${TARGET} PROPERTIES OUTPUT_NAME "caesium-image-compressor") - target_link_libraries(${TARGET} PRIVATE Qt${QT_VERSION_MAJOR}::Widgets Qt${QT_VERSION_MAJOR}::Core Qt${QT_VERSION_MAJOR}::Gui Qt${QT_VERSION_MAJOR}::Concurrent Qt${QT_VERSION_MAJOR}::Svg Qt${QT_VERSION_MAJOR}::Network Qt${QT_VERSION_MAJOR}::Sql caesium) + target_link_libraries(${TARGET} PRIVATE Qt${QT_VERSION_MAJOR}::Widgets Qt${QT_VERSION_MAJOR}::Core Qt${QT_VERSION_MAJOR}::Gui Qt${QT_VERSION_MAJOR}::Concurrent Qt${QT_VERSION_MAJOR}::Svg Qt${QT_VERSION_MAJOR}::Network Qt${QT_VERSION_MAJOR}::Sql) endif () add_subdirectory(tests)