Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comfyui extra_model_paths hard coded #130

Closed
WSJUSA opened this issue Sep 16, 2023 · 2 comments · Fixed by #135
Closed

Comfyui extra_model_paths hard coded #130

WSJUSA opened this issue Sep 16, 2023 · 2 comments · Fixed by #135
Labels
bug Something isn't working

Comments

@WSJUSA
Copy link

WSJUSA commented Sep 16, 2023

It seems the management of the model paths for comfyui hard codes possible paths in extra_model_paths.yaml

This limits being able to define new directories or subdirectories, as the yaml reader rewrites it on every instantiation of Comfyui

in this process:

public override Task SetupModelFolders(

maybe this could be more flexible to not overwrite new paths, or have a way to add new paths to a config

thanks

@mohnjiles
Copy link
Contributor

Hi there, you should certainly be able to add your own extra paths to the yaml file, are you saying we're overwriting the entire file or just that stability-matrix section? If the former, that's a bug. You should be able to add extra sections to the yaml as shown here, we should only be overwriting the section named stability-matrix.

Also, in the newer 2.4.x versions, we've added an option to install packages without symlinks or config modifications - you can try using Symlinks or just set it to None if you'd rather manage it yourself.
image

We will be adding an option to switch these at runtime instead of having to reinstall the package to switch the "Shared Folder Strategy".

@mohnjiles
Copy link
Contributor

Scratch that, just tried it myself - will get this fixed in the next version. Thanks for the report!

@mohnjiles mohnjiles added the bug Something isn't working label Sep 16, 2023
@ionite34 ionite34 mentioned this issue Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants