Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sparse_init doesn't use provided rng fully #1185

Closed
bertini97 opened this issue Jan 7, 2025 · 3 comments · Fixed by #1188
Closed

sparse_init doesn't use provided rng fully #1185

bertini97 opened this issue Jan 7, 2025 · 3 comments · Fixed by #1188
Labels
bug Something isn't working

Comments

@bertini97
Copy link

If I pass the same rng::AbstractRNG to sparse_init, the entries are placed differently every time. This is because rng is not passed to shuffle. Is this intended?
@avik-pal
Copy link
Member

avik-pal commented Jan 7, 2025

That's a great catch. It isn't the expected behavior. Want to make a PR?

@avik-pal avik-pal added the bug Something isn't working label Jan 7, 2025
@bertini97
Copy link
Author

I'm not sure how to do it in a map... Feel free to fix it upstream, I would like for this to be merged asap.

@avik-pal avik-pal mentioned this issue Jan 7, 2025
Merged
@bertini97
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass in RNG to shuffle LuxDL/Lux.jl
2 participants
@avik-pal @bertini97