little bug using Bing translator

[edwardyeung]

Description

I was trying to add Bing translator.

To Reproduce

Steps to reproduce the behavior, e.g.:

1. Go to 'Language'
2. add new dictionary, choose embedded, and click the little arrow to test, you will find everything is normal
3. Go to book, and click any words to translate via Bing, then the error shows up.

Error logs

Version: 3.7.0
You were on: http://192.168.50.215:5001/read/17
You were trying to access: http://192.168.50.215:5001/bing/search/4/find/https://www.bing.com/translator%3Ftext=[LUTE]

Other
installed in OrangePi 3 LTS. Python 3.10

[jzohrab]

Hi @edwardyeung , thanks for the message. Can you paste the URL that you set up in the dictionary list for the language? A screenshot is fine. Cheers!

[edwardyeung]

url:
https://www.bing.com/translator?text=[LUTE]

I thought the problem caused by the question mark at first, so I tried "https://www.bing.com/translator", and had no luck.

[jzohrab]

I think you need the from and to parameters as well. For example, here is from Thai to English:

https://www.bing.com/translator/?from=th&to=en&text=[LUTE]

[edwardyeung]

by the way, I don't know if you are interested or not.
I am an obsidian (a note taking app) user, there is a plugin for obsidian called custom frame which solves the problems of some websites forbidding using iframe and make users access google keep, google translate...etc

here is the plugin source.
https://github.com/Ellpeck/ObsidianCustomFrames/blob/master/src/frame.ts

[edwardyeung]

I think you need the from and to parameters as well. For example, here is from Thai to English:

https://www.bing.com/translator/?from=th&to=en&text=[LUTE]

Brilliant!

[edwardyeung]

I think you need the from and to parameters as well. For example, here is from Thai to English:

https://www.bing.com/translator/?from=th&to=en&text=[LUTE]

sadly, still had no luck using the same url.

[jzohrab]

Well, this is annoying! Back at my computer, trying further on my machine, and I have the same issue :-( . It used to work, but I couldn't test it in CI so ... broken silently, which sucks terribly. Thanks for the ping, there are some things that just can't be tested easily unless it's done manually (unless, of course, I just don't know what I'm missing).

Anyway, reproducing: For Spanish, I have the following as an embedded term dict:

https://www.bing.com/translator/?from=es&to=en&text=[LUTE]

i.e.

and I got this error:

Thank you @edwardyeung , I'll try to get a fix out very soon, as it's nice to have the embedded bing lookup. Cheers!

[jzohrab]

OK, this is fixed in develop now. Here's using Bing as a term lookup:

and as a sentence lookup:

[jzohrab]

Launched in 3.8.0.