Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow listing of unknown terms in term listing, default to min status 1 #544

Closed
3 tasks done
jzohrab opened this issue Dec 22, 2024 · 4 comments
Closed
3 tasks done

Allow listing of unknown terms in term listing, default to min status 1 #544

jzohrab opened this issue Dec 22, 2024 · 4 comments
Labels
fixed Fixed in develop or master, to be launched. tweak Adjustment to the code -- not a new feature, just minor mods/tweaks

Comments

@jzohrab
Copy link
Collaborator

jzohrab commented Dec 22, 2024 •
edited
Loading

People can add status=0 terms, but currently can't see them; they should be able to, it's just data.

Considerations/steps:

  • add to filter combo box
  • if status lower bound isn't explicitly set, should default to 1
  • add test?
@jzohrab jzohrab added the tweak Adjustment to the code -- not a new feature, just minor mods/tweaks label Dec 22, 2024
@jzohrab jzohrab added this to Lute-v3 Dec 22, 2024
@jzohrab jzohrab moved this to Todo in Lute-v3 Dec 22, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Dec 22, 2024

Thank you, @wwqwq2313 ! I'll take a look.

@jzohrab jzohrab moved this from Todo to In Progress in Lute-v3 Dec 22, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Dec 23, 2024

In progress, running tests.

@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Dec 23, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Dec 23, 2024

Fixed in develop

@jzohrab jzohrab moved this from In Progress to Done in Lute-v3 Dec 23, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Dec 25, 2024

Launched in 3.8.0.

@jzohrab jzohrab closed this as completed Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Fixed in develop or master, to be launched. tweak Adjustment to the code -- not a new feature, just minor mods/tweaks
Projects
Lute-v3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jzohrab and others