Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on sentences shouldn't change the current page #530

Closed
4 tasks done
jzohrab opened this issue Dec 7, 2024 · 2 comments
Closed
4 tasks done

Clicking on sentences shouldn't change the current page #530

jzohrab opened this issue Dec 7, 2024 · 2 comments
Labels
fixed Fixed in develop or master, to be launched. tweak Adjustment to the code -- not a new feature, just minor mods/tweaks

Comments

@jzohrab
Copy link
Collaborator

jzohrab commented Dec 7, 2024

Currently, clicking on a sentence to open its page sets the book current text id, but that's a hassle as it changes reading positions etc sometimes. Suggest a different route that doesn't change the current text id.

To do:

  • try adding route to peek at a page
  • change sentence listing to use the new peek route
  • test to ensure peek doesn't set TxStartDate, BkCurrentTxID
  • ... ensure it works?
@jzohrab jzohrab added the tweak Adjustment to the code -- not a new feature, just minor mods/tweaks label Dec 7, 2024
@jzohrab jzohrab added this to Lute-v3 Dec 7, 2024
@jzohrab jzohrab moved this to Todo in Lute-v3 Jan 3, 2025
@jzohrab jzohrab moved this from Todo to In Progress in Lute-v3 Jan 3, 2025
@jzohrab jzohrab moved this from In Progress to Todo in Lute-v3 Jan 3, 2025
@jzohrab
Copy link
Collaborator Author

jzohrab commented Jan 3, 2025

Fixed in develop

@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Jan 3, 2025
@jzohrab jzohrab moved this from Todo to Done in Lute-v3 Jan 3, 2025
@jzohrab
Copy link
Collaborator Author

jzohrab commented Jan 6, 2025

Launched in 3.9.0.

@jzohrab jzohrab closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Fixed in develop or master, to be launched. tweak Adjustment to the code -- not a new feature, just minor mods/tweaks
Projects
Archived in project
Development

No branches or pull requests

1 participant