Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move language.all_dictionaries to repository #515

Closed
jzohrab opened this issue Nov 10, 2024 · 2 comments
Closed

Move language.all_dictionaries to repository #515

jzohrab opened this issue Nov 10, 2024 · 2 comments
Assignees
@jzohrab
Labels
code-improvement Make code/structure better

Comments

@jzohrab
Copy link
Collaborator

jzohrab commented Nov 10, 2024

This method uses the implicit db.session which is being broken as part of #503.

To change:

lute/term/routes.py:        language_dicts=Language.all_dictionaries(),

lute/models/language.py:        for lang in Language.query.all():

tests/orm/test_Language.py:    assert json.dumps(Language.all_dictionaries()) == exp
@jzohrab jzohrab added the code-improvement Make code/structure better label Nov 10, 2024
@jzohrab jzohrab added this to Lute-v3 Nov 10, 2024
@jzohrab jzohrab moved this to Todo in Lute-v3 Nov 10, 2024
@jzohrab jzohrab self-assigned this Nov 10, 2024
@jzohrab jzohrab moved this from Todo to Done in Lute-v3 Nov 10, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Nov 10, 2024

Done in develop

@jzohrab
Copy link
Collaborator Author

jzohrab commented Nov 16, 2024

In 3.6.0 release.

@jzohrab jzohrab closed this as completed Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzohrab jzohrab

Labels
code-improvement Make code/structure better
Projects
Lute-v3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jzohrab