Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese not handling repeat char correctly #488

Closed
jzohrab opened this issue Oct 5, 2024 · 2 comments
Closed

Japanese not handling repeat char correctly #488

jzohrab opened this issue Oct 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working fixed Fixed in develop or master, to be launched.

Comments

@jzohrab
Copy link
Collaborator

jzohrab commented Oct 5, 2024

Sample current result:

image

For text:

聞こえる行く先々

新品 あたいのBody
Singing mi nah tell nuh lie
金銀 あたいの価値

Also spaces being removed for some reason.

@jzohrab jzohrab self-assigned this Oct 5, 2024
@jzohrab jzohrab added the bug Something isn't working label Oct 5, 2024
@jzohrab jzohrab added this to Lute-v3 Oct 5, 2024
@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Oct 5, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Oct 5, 2024

Fixed in develop for the "repeat" character.

Mecab is stripping space characters ... I didn't want to fix this one just yet as I think it's rare, and have enough to do.

Singing mi nah tell nuh lie parsed yields

Singing	5	45
mi	5	38
nah	5	38
tell	5	38
nuh	5	38
lie	5	38
	0	4
EOP	3	7

@jzohrab jzohrab moved this to Done in Lute-v3 Oct 5, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Oct 7, 2024

In release 3.5.5.

@jzohrab jzohrab closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Fixed in develop or master, to be launched.
Projects
Archived in project
Development

No branches or pull requests

1 participant