Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show component terms in the order the appear in the term in popup #372

Closed
jzohrab opened this issue Mar 25, 2024 · 3 comments
Closed

Show component terms in the order the appear in the term in popup #372

jzohrab opened this issue Mar 25, 2024 · 3 comments
Labels
fixed Fixed in develop or master, to be launched. tweak Adjustment to the code -- not a new feature, just minor mods/tweaks

Comments

@jzohrab
Copy link
Collaborator

jzohrab commented Mar 25, 2024

From Discord:

The new component terms are nice to have, but it doesn't show them in the same order of the compound term, my guess is, it shows them in the order they were added to my terms' list.

Image

I actually don't know how it sorts the terms :-P, it might be alphabetical or something. Basically it just does a match of the terms and throws them out there, it doesn't try to locate them within the string. That gets fairly complicated, but that's what's done for the rendering for the reading screen -- maybe the rendering calculations can be repurposed so that the components are shown in more-or-less the same order that they're found in the term.

This would need to somehow use the rendering calculation to locate the components in the original multi-word term, and then print them out.

@jzohrab jzohrab added the tweak Adjustment to the code -- not a new feature, just minor mods/tweaks label Mar 25, 2024
@jzohrab jzohrab added this to Lute-v3 Mar 25, 2024
@jzohrab jzohrab added this to Lute-v3 Apr 1, 2024
@jzohrab jzohrab moved this to In Progress in Lute-v3 Apr 30, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Apr 30, 2024

Before the change:

Image

After:

Image

@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Apr 30, 2024
@jzohrab jzohrab moved this from In Progress to Done in Lute-v3 Apr 30, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Apr 30, 2024

fixed in develop

@jzohrab
Copy link
Collaborator Author

jzohrab commented May 7, 2024

Launched in 3.3.3

@jzohrab jzohrab closed this as completed May 7, 2024
@github-project-automation github-project-automation bot moved this to Done in Lute-v3 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Fixed in develop or master, to be launched. tweak Adjustment to the code -- not a new feature, just minor mods/tweaks
Projects
Archived in project
Development

No branches or pull requests

1 participant