Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or make optional the ['Dictionary URI must contain ###'] #302

Closed
emanuelps2708 opened this issue Mar 3, 2024 · 6 comments
Closed
Labels
enhancement New feature or request fixed Fixed in develop or master, to be launched.

Comments

@emanuelps2708
Copy link

Is your feature request related to a problem? Please describe.
Hi jz, I'm helping to add some languages to the lute language project and in a lot of languages there are online dictionaries but they don't have a way to put ### in the link because some of them require to type the word manually

Describe the solution you'd like
Maybe remove the warning or make it optional

Add any other context or screenshots about the feature request here.
An example are the dictionaries from IDS https://ids.clld.org/ if I try to add ### it gives an error
image

@jzohrab jzohrab added the enhancement New feature or request label Mar 4, 2024
@jzohrab jzohrab added this to Lute-v3 Mar 4, 2024
@jzohrab
Copy link
Collaborator

jzohrab commented Mar 4, 2024

Sure, optional is ok, seems like a user choice to me. Cheers :-)

@jzohrab
Copy link
Collaborator

jzohrab commented Mar 4, 2024

Dev size est:

  • change form validation - show warning?
  • check dictionary test link, test with embedded or popup
  • any documentation changes?

@emanuelps2708
Copy link
Author

emanuelps2708 commented Mar 14, 2024

Hi @jzohrab , Adrian7 (one of the contributors of the Lute Language Support Project) asked on the questions thread about a possible solution to this issue, Imam found a solution, it would be to create a fake parameter, for example when Adrian tried to add a Cherokee dictionary "https://www.cherokeedictionary.net/" it gave the error but adding "?lute=###" fixed it so the new link would be "https://www.cherokeedictionary.net/?lute=###". With that I think the issue is solved, just maybe if you can add this to the manual that could be very helpful, the thread link is https://discord.com/channels/1074759089051160647/1155012911299833876/1217895051926175756

@jzohrab
Copy link
Collaborator

jzohrab commented Mar 15, 2024

Good idea @emanuelps2708 - I added that, and did that total page revision I've been putting off. It should be up in a few minutes at https://jzohrab.github.io/lute-manual/usage/languages/dictionaries.html.

@emanuelps2708
Copy link
Author

Thank you jz, the manual page looks amazing, great effort ;)

@jzohrab jzohrab added this to Lute-v3 Apr 1, 2024
@jzohrab jzohrab moved this to Todo in Lute-v3 Jul 2, 2024
@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Nov 9, 2024
@jzohrab
Copy link
Collaborator

jzohrab commented Nov 16, 2024

In 3.6.0 release.

@jzohrab jzohrab closed this as completed Nov 16, 2024
@github-project-automation github-project-automation bot moved this to Done in Lute-v3 Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Fixed in develop or master, to be launched.
Projects
Archived in project
Development

No branches or pull requests

2 participants