Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various RTL errors #165

Open
M-Biggles opened this issue Feb 1, 2024 · 7 comments
Open

Various RTL errors #165

M-Biggles opened this issue Feb 1, 2024 · 7 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@M-Biggles
Copy link

M-Biggles commented Feb 1, 2024

Several RTL bugs -- (moving to new issues if needed)

Remaining

C. (Reading page) Page changing bar at top should be RTL instead of LTR;

C

E. Numbers with , and . are ordered wrongly. BIDI issue?

Expected:
2

Current:
1

F. PDF import of RTL languages is broken

G. PDF export of RTL languages is broken

Fixed items

@M-Biggles
Copy link
Author

Ok, I've never reported bugs before, so I'm hoping these are easy enough to understand and find.

@jzohrab
Copy link
Collaborator

jzohrab commented Feb 1, 2024

Thank you very much! I had notes on these and was going to make an issue, so I appreciate you taking the time. I hope to address these soon-ish. Going by feel, they don't look like they'd have any blockers, except perhaps for the slider bar item C. I'll add this to the backlog close to the top, and as I start work on it I'll add notes here. Cheers!

@jzohrab jzohrab added the enhancement New feature or request label Feb 1, 2024
@jzohrab jzohrab added this to Lute-v3 Feb 1, 2024
@jzohrab jzohrab added the bug Something isn't working label Feb 2, 2024
@M-Biggles
Copy link
Author

I found this resource and thought it might be a useful guide.

https://rtlstyling.com/posts/rtl-styling/

@M-Biggles
Copy link
Author

M-Biggles commented Feb 4, 2024

@jzohrab

I've added a few more here (E, F + G) and will stuff keep adding more, but that's the most of it now. If we need to split any into separate issues, we can do so.

@jzohrab
Copy link
Collaborator

jzohrab commented Feb 4, 2024

E is due to how Lute tokenizes the elements: in "1,900", "1" becomes a token, then ",", then "900", so those are output backwards. fyi only. :-) It's a tough problem.

F and G pdf stuff: PDF is brutal to work with. https://jzohrab.github.io/lute-manual/faq/books/pdf-import.html gives some brief notes about the problem. fyi only again.

@M-Biggles
Copy link
Author

M-Biggles commented Feb 4, 2024

Understood, thanks for the further info! Focus on the easy ones and get to the tricky stuff on another day. :)

So, how are the texts tokenised? I'd like to explore it a little. Which files does Lute create and work with? Maybe I can think of something from a linguistics perspective.

@jzohrab jzohrab mentioned this issue Feb 6, 2024
@jzohrab
Copy link
Collaborator

jzohrab commented Feb 6, 2024

Some of these are tougher than others, so I'll pull out smaller issues from the main as I can, and will reference this issue from them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants