Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review directories which linters are run on and possibly allow customisation #267

Closed
justafish opened this issue Jul 16, 2021 · 3 comments
Closed

Review directories which linters are run on and possibly allow customisation #267

justafish opened this issue Jul 16, 2021 · 3 comments
Assignees
@deviantintegral

Comments

@justafish
Copy link
Member

No description provided.

@deviantintegral
Copy link
Member

This is done for phpcs at Lullabot/drainpipe-dev#23

@hawkeyetwolf
Copy link
Contributor

Made PHPStan configurable in Lullabot/drainpipe-dev#32

@deviantintegral
Copy link
Member

There was an issue with this with lullabot.com, but it's since been fixed.

We think this is just adding defaults at https://github.com/Lullabot/drainpipe/blob/main/tasks/test.yml#L5-L17. @deviantintegral will take this as we recently did something similar in client code.

@deviantintegral deviantintegral self-assigned this Sep 28, 2023
@deviantintegral deviantintegral transferred this issue from Lullabot/drainpipe-dev Sep 28, 2023
@deviantintegral deviantintegral mentioned this issue Sep 29, 2023
Merged
justafish pushed a commit that referenced this issue Oct 5, 2023
@deviantintegral
Convert variables to support defaults with override #267 (#268)
91b8a23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deviantintegral deviantintegral

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deviantintegral @justafish @hawkeyetwolf