Revert "fix(pipelines): CodeBuild projects are hard to tell apart (aw…

…s#18492)" This reverts commit f6dab8d.
LukvonStrom · Jan 27, 2022 · 6fa16f9 · 6fa16f9
1 parent 0548da2
commit 6fa16f9
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 95 deletions.
diff --git a/packages/@aws-cdk/pipelines/test/codepipeline/codebuild-step.test.ts b/packages/@aws-cdk/pipelines/test/codepipeline/codebuild-step.test.ts
@@ -43,28 +43,6 @@ test('additionalinputs creates the right commands', () => {
   });
 });
 
-test('CodeBuild projects have a description', () => {
-  new cdkp.CodePipeline(pipelineStack, 'Pipeline', {
-    synth: new cdkp.CodeBuildStep('Synth', {
-      commands: ['/bin/true'],
-      input: cdkp.CodePipelineSource.gitHub('test/test', 'main'),
-    }),
-  });
-
-  // THEN
-  Template.fromStack(pipelineStack).hasResourceProperties(
-    'AWS::CodeBuild::Project',
-    {
-      Description: {
-        'Fn::Join': [
-          '',
-          ['Pipeline step ', { Ref: 'Pipeline9850B417' }, '/Build/Synth'],
-        ],
-      },
-    },
-  );
-});
-
 test('long duration steps are supported', () => {
   // WHEN
   new cdkp.CodePipeline(pipelineStack, 'Pipeline', {

diff --git a/packages/@aws-cdk/pipelines/test/integ.newpipeline-with-vpc.expected.json b/packages/@aws-cdk/pipelines/test/integ.newpipeline-with-vpc.expected.json
@@ -1363,18 +1363,6 @@
         "Cache": {
           "Type": "NO_CACHE"
         },
-        "Description": {
-          "Fn::Join": [
-            "",
-            [
-              "Pipeline step ",
-              {
-                "Ref": "Pipeline9850B417"
-              },
-              "/Build/Synth"
-            ]
-          ]
-        },
         "EncryptionKey": "alias/aws/s3",
         "VpcConfig": {
           "SecurityGroupIds": [
@@ -1962,18 +1950,6 @@
         "Cache": {
           "Type": "NO_CACHE"
         },
-        "Description": {
-          "Fn::Join": [
-            "",
-            [
-              "Pipeline step ",
-              {
-                "Ref": "Pipeline9850B417"
-              },
-              "/UpdatePipeline/SelfMutate"
-            ]
-          ]
-        },
         "EncryptionKey": "alias/aws/s3",
         "VpcConfig": {
           "SecurityGroupIds": [
@@ -2316,18 +2292,6 @@
         "Cache": {
           "Type": "NO_CACHE"
         },
-        "Description": {
-          "Fn::Join": [
-            "",
-            [
-              "Pipeline step ",
-              {
-                "Ref": "Pipeline9850B417"
-              },
-              "/Assets/FileAsset1"
-            ]
-          ]
-        },
         "EncryptionKey": "alias/aws/s3",
         "VpcConfig": {
           "SecurityGroupIds": [
@@ -2429,18 +2393,6 @@
         "Cache": {
           "Type": "NO_CACHE"
         },
-        "Description": {
-          "Fn::Join": [
-            "",
-            [
-              "Pipeline step ",
-              {
-                "Ref": "Pipeline9850B417"
-              },
-              "/Assets/FileAsset2"
-            ]
-          ]
-        },
         "EncryptionKey": "alias/aws/s3",
         "VpcConfig": {
           "SecurityGroupIds": [

diff --git a/packages/@aws-cdk/pipelines/test/integ.newpipeline.expected.json b/packages/@aws-cdk/pipelines/test/integ.newpipeline.expected.json
@@ -2044,18 +2044,6 @@
         "Cache": {
           "Type": "NO_CACHE"
         },
-        "Description": {
-          "Fn::Join": [
-            "",
-            [
-              "Pipeline step ",
-              {
-                "Ref": "Pipeline9850B417"
-              },
-              "/Build/Synth"
-            ]
-          ]
-        },
         "EncryptionKey": "alias/aws/s3"
       }
     },
@@ -2355,18 +2343,6 @@
         "Cache": {
           "Type": "NO_CACHE"
         },
-        "Description": {
-          "Fn::Join": [
-            "",
-            [
-              "Pipeline step ",
-              {
-                "Ref": "Pipeline9850B417"
-              },
-              "/UpdatePipeline/SelfMutate"
-            ]
-          ]
-        },
         "EncryptionKey": "alias/aws/s3"
       }
     }

diff --git a/packages/@aws-cdk/pipelines/test/testhelpers/matchers.ts b/packages/@aws-cdk/pipelines/test/testhelpers/matchers.ts
@@ -26,7 +26,7 @@ class StringLike extends Matcher {
 
   public test(actual: any): MatchResult {
     if (typeof(actual) !== 'string') {
-      throw new Error(`Expected string but found ${typeof(actual)} ${JSON.stringify(actual)}`);
+      throw new Error(`Expected string but found ${typeof(actual)}`);
     }
     const re = new RegExp(`^${this.pattern.split('*').map(escapeRegex).join('.*')}$`);