[pnpm] Move datefns to external adapters #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other important info, Typescript gave me a lot of trouble, so I couldn't really check for the "unit testing". 😅 Lint/Typescript/Build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdapterDateFnsto/packages/adapters/x-adapter-date-fns-v2AdapterDateFnsV3to/packages/adapters/x-adapter-date-fns-v3/packages/adapters/x-adapter-commonTypescript gives us a lot of trouble when trying to export the correct libs from all different places. It would be good to have a full review of the changes, since nextjs only compiles a page when it is rendered, I don't know if there are side effects. From what I could test, the code worked out of the box in the pages that use it.