Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up settings #85

Open
LukasGrebe opened this issue Dec 3, 2023 · 4 comments
Open

Clean up settings #85

LukasGrebe opened this issue Dec 3, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@LukasGrebe
Copy link
Owner

Settings have gotten more complex over time and are now confusing.

It may be preferable to offer just a few settings such as USB device dropdown and then refer to the ebusd documentation and offer a field for custom command line options.

@LukasGrebe
Copy link
Owner Author

Maybe we can also use sensible defaults such as enabling TCP access on a predefined port, or offer an ingress method to interact via ebusctl

@cociweb
Copy link
Collaborator

cociweb commented Dec 3, 2023

Well, In my case, I don't open any port for the ebusd. (neither TCP nor HTTP nor ingress) I've retrieve/publish info from/to mqtt(s). I don't think It would be possible to reproduce my configuration (with gui) with less configuration record.

What do you think about? Which part of it is in your mind?

@LukasGrebe
Copy link
Owner Author

LukasGrebe commented Jan 8, 2025

i'm thinking moving all of the option to "custom comand line options" and removing most of

schema:
mode: "list(enh|ens|udp)?"
device: "device(subsystem=tty)?"
network_device: "str?"
latency: "int(0,10000)?"
pollinterval: "int(0,3600)?"
http: "bool?"
readonly: "bool?"
scanconfig: "bool?"
configpath: "str?"
commandline_options: "str?"
accesslevel: "str?"
logdir_name: "str?"
logdir_files_number: "int?"
logdir_files_size: "int?"
loglevel_all: "list(error|notice|info|debug)?"
loglevel_network: "list(error|notice|info|debug)?"
loglevel_bus: "list(error|notice|info|debug)?"
loglevel_update: "list(error|notice|info|debug)?"
loglevel_main: "list(error|notice|info|debug)?"
loglevel_other: "list(error|notice|info|debug)?"
mqtthost: "str?"
mqttport: "int?"
mqttuser: "str?"
mqttpass: "str?"
mqttjson: "bool?"
mqttlog: "bool?"
mqttretain: "bool?"
mqttint: "str?"
mqttvar: "str?"
mqtttopic: "str?"
lograwdata: "bool?"
lograwdatafile: "str?"
lograwdatasize: "int?"

@LukasGrebe
Copy link
Owner Author

as for ports - there had been a few requests to provide access to the running ebusd outside of homeassistantOS
as for ingress - there had been questions on how to interact with ebusd via console, so the idea was to spawn a web based console with wich users could directly access ebusctl (like the terminal addon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants