Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.3.0 - ClientSideToggleMenuItem not found #727

Closed
3 of 4 tasks
mrd83 opened this issue Aug 10, 2024 · 1 comment · Fixed by #835
Closed
3 of 4 tasks

v10.3.0 - ClientSideToggleMenuItem not found #727

mrd83 opened this issue Aug 10, 2024 · 1 comment · Fixed by #835
Labels
bug Something isn't working

Comments

@mrd83
Copy link

mrd83 commented Aug 10, 2024

Steps to reproduce

NOTE: the issue is directly caused by @Andrews54757 's FastStream extension - but since it uses all of the classes from YouTube.js I sincerely hope this report is actually valid. Normally I'd create a PR instead - but since I don't use YouTube.js >directly< - I'm unable to test the code.

  1. Start yt video with debugging console opened
  2. Wait for the message to appear.

Failure Logs

[YOUTUBEJS][Parser]: Error: ClientSideToggleMenuItem not found!
This is a bug, want to help us fix it? Follow the instructions at https://github.com/LuanRT/YouTube.js/blob/main/docs/updating-the-parser.md or report it at https://github.com/LuanRT/YouTube.js/issues!
Introspected and JIT generated this class in the meantime:
(...)

Expected behavior

No such error

Current behavior

Here's auto-generated class:

class ClientSideToggleMenuItem extends YTNode {
  static type = 'ClientSideToggleMenuItem';
  default_text: Text;
  default_icon: {
    icon_type: string
  };
  toggled_text: Text;
  toggled_icon: {
    icon_type: string
  };
  menu_item_identifier: string;
  command: {
    click_tracking_params: string,
    toggle_live_chat_timestamps_endpoint: NavigationEndpoint
  };
  constructor(data: RawNode) {
    super();
    this.default_text = new Text(data.defaultText);
    this.default_icon = {
      icon_type: data.defaultIcon.iconType
    };
    this.toggled_text = new Text(data.toggledText);
    this.toggled_icon = {
      icon_type: data.toggledIcon.iconType
    };
    this.menu_item_identifier = data.menuItemIdentifier;
    this.command = {
      click_tracking_params: data.command.clickTrackingParams,
      toggle_live_chat_timestamps_endpoint: new NavigationEndpoint(data.command.toggleLiveChatTimestampsEndpoint)
    };
  }
}

Proof:
issue 1 - ClientSideToggleMenuItem

Version

Default

Anything else?

There's another: "ShortsLockupView". Should I also report it?
issue 2a - ShortsLockupView

Checklist

  • I am running the latest version.
  • I checked the documentation and found no answer.
  • I have searched the existing issues and made sure this is not a duplicate.
  • I have provided sufficient information.
@mrd83 mrd83 added the bug Something isn't working label Aug 10, 2024
@iBicha
Copy link
Contributor

iBicha commented Aug 16, 2024

#595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants