Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ES and Chrome target versions to reflect actual code #718

Closed
wants to merge 2 commits into from

Conversation

darktohka
Copy link

Fixes #716 and #717.

The ES target version is bumped to es2018 to support the new regex that was introduced in 04369be.

The browser target version is bumped to chrome63 to support the async generators used since fb68e6b.

Copy link

@rogerpadilla rogerpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing is there are failing unit tests.

@LuanRT
Copy link
Owner

LuanRT commented Sep 16, 2024

I just updated these values while working on something unrelated, so I'll close this one as it's no longer needed. But thank you for the PR, it's always appreciated.

@LuanRT LuanRT closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

04369be error TS1501: This regular expression flag is only available when targeting 'es2018' or later.
3 participants